[tbb-bugs] #16722 [Tor Browser]: New tab "Tiles" feature re-enabled after upgrade

[Tor Bug Tracker & Wiki]

#16722: New tab "Tiles" feature re-enabled after upgrade
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:  tbb-team
  mikeperry              |     Status:  needs_review
         Type:  defect   |  Milestone:
     Priority:  major    |    Version:
    Component:  Tor      |   Keywords:  tbb-5.0,tbb-updater,
  Browser                |  TorBrowserTeam201508R, GeorgKoppen201508R
   Resolution:           |  Parent ID:
Actual Points:           |
       Points:           |
-------------------------+-------------------------------------------------

Comment (by gk):

 Replying to [comment:6 mikeperry]:
 > I attempted to create a general Torbutton pref flipping function for
 this kind of stuff (specifically #16730), but resetting this newtab pref
 from there caused it to be completely ignored, even after restart!
 https://gitweb.torproject.org/mikeperry/torbutton.git/commit/?h=bug16730
 >
 > Is there some reason why we need to flip this pref in the browser? I
 think I'd rather not clutter up our browser repo with such hacks as this,
 thats why I tried to do it in Torbutton..

 Yeah, if we can avoid the browser repo that would be good.

 > But I have no idea why that is not working.

 I guess this is due to
 {{{
 // Re-set the default in case the user clears the pref
         case this._observedPrefs.enhanced:
           this._setDefaultEnhanced();
           break;
 }}}
 in the observer.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16722#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online