[tbb-bugs] #16497 [Tor Browser]: debug build failure in nsContentUtils.cpp

[Tor Bug Tracker & Wiki]

#16497: debug build failure in nsContentUtils.cpp
-----------------------------+--------------------------
     Reporter:  mcs          |      Owner:  tbb-team
         Type:  defect       |     Status:  needs_review
     Priority:  normal       |  Milestone:
    Component:  Tor Browser  |    Version:
   Resolution:               |   Keywords:
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+--------------------------
Changes (by mcs):

 * status:  needs_information => needs_review


Comment:

 Replying to [comment:3 gk]:
 > So, to understand this fully: This is no error just happening in a debug
 build. Rather, this is actually a thing clang does not like (while GCC and
 mingw-w64 + our cross-compiler don't have an issue with it)?

 No, I am 99% sure this is a problem that affects all debug builds.  I only
 mentioned clang because the error text that it generates are different
 than those that gcc generates (never mind).  Let me try to explain more
 clearly.

 If you look at the #13670 patch, here:
 https://gitweb.torproject.org/tor-
 browser.git/diff/dom/base/nsContentUtils.cpp?h=tor-
 browser-38.1.0esr-5.0-1&id=ac7de4b0b756891a3835e738ebe534c44d4855c4
 you will see that Arthur removed the aLoadingDocument parameter from
 nsContentUtils::LoadImage() but he neglected to remove the
 NS_PRECONDITION() that references it.  Does this fix make sense now?

 Also, I pushed this fix to the brade tor-browser repo to make it easier to
 review and merge:
 https://gitweb.torproject.org/user/brade/tor-
 browser.git/commit/?h=bug16497-01&id=bfdfcccae99d1af38b3320eb7409377bd0ebc154

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16497#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online