[tbb-bugs] #15842 [Tor Browser]: Refactor #10280 patch for ESR-38

[Tor Bug Tracker & Wiki]

#15842: Refactor #10280 patch for ESR-38
-------------------------+--------------------------
 Reporter:  cypherpunks  |          Owner:  tbb-team
     Type:  defect       |         Status:  new
 Priority:  normal       |      Milestone:
Component:  Tor Browser  |        Version:
 Keywords:  ff38-esr     |  Actual Points:
Parent ID:               |         Points:
-------------------------+--------------------------
 Mozilla's team reviewed and discussed our patch for #10280.
 https://bugzilla.mozilla.org/show_bug.cgi?id=817255#c20

 First, after new GMP (https://wiki.mozilla.org/GeckoMediaPlugins), patch
 with ESR-38 could be wrong/invalid/incomplete/broken.

 Second, they don't want new UI elements for about:addons (Plugins). Do we
 need this UI elements? Isn't Torbutton's menu (Security settings) should
 be enough to allow or disallow plugins?
 Our FAQ https://www.torproject.org/docs/faq.html.en#TBBFlash says nothing
 about steps to allow Flash neither?

 In general, we could to simplify patch a lot using all comments from
 review, or discuss about race conditions that simplify could lead to.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/15842>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online