[metrics-team] CollecTor exit-list archive bug

[iwakeh]

On 01/10/2017 05:51 PM, iwakeh wrote:
> 
> 
> On 01/10/2017 05:00 PM, Wojtek Porczyk wrote:
>> Hello, Metrics Team,
> 
>> I belive I found a bug in CollecTor. Since 2016-11-01-09-02-00 the exit list
>> archive features "@type torperf" instead of "tordnsel", which makes it
>> unreadable in at least stem (python) parser.
> 
>>> [woju at REDACTED ~/tmp/exit-list-2016-11/01]$ head 2016-11-01-08-02-00
>>> @type tordnsel 1.0
>>> Downloaded 2016-11-01 08:02:00
>>> ExitNode 0011BD2485AD45D984EC4159C88FC066E5E3300E
> [snip]
> 
> 
>> Patch fixing this:
> 
>> diff --git a/src/main/java/org/torproject/collector/exitlists/ExitListDownloader.java b/src/main/java/org/torproject/collector/exitlists/ExitListDownloader.java
>> index 3c2f403..26fbe4b 100644
>> --- a/src/main/java/org/torproject/collector/exitlists/ExitListDownloader.java
>> +++ b/src/main/java/org/torproject/collector/exitlists/ExitListDownloader.java
>> @@ -76,7 +76,7 @@ public class ExitListDownloader extends CollecTorMain {
>>      try {
>>        logger.debug("Downloading exit list...");
>>        StringBuilder sb = new StringBuilder();
>> -      sb.append(Annotation.Torperf.toString());
>> +      sb.append(Annotation.ExitList.toString());
>>        sb.append("Downloaded " + dateTimeFormat.format(downloadedDate)
>>            + "\n");
>>        URL url = config.getUrl(Key.ExitlistUrl);
> 
>> You may also pull tag fix-exit-list from https://github.com/woju/collector
>> (commit e885283).
> 
> Thanks for reporting and analyzing this!
> The patch looks fine!
> 
> 
>> Can you also fix the already posted files at collector.torproject.org?
> 
> 
> These need to be fixed too, that's true.
> 
> Kind regards,
> iwakeh
> 

Next steps can be found in trac.torproject.org in ticket #21195.

Kind regards,
iwakeh



-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.torproject.org/pipermail/metrics-team/attachments/20170111/3ed76e4a/attachment.sig>