[metrics-team] OnionStats - roadmap?

[Anathema]

On 12/08/2016 17:21, Karsten Loesing wrote:
> Hi Anathema,
> 
> On 08/08/16 17:50, Anathema wrote:
>> On 08/08/2016 15:13, Karsten Loesing wrote:
>>>
>>> Maybe an example helps here: assume you have 55 relays and 45
>>> bridges and ask for offset=50 and limit=10.  Your implementation
>>> will return relays 51 to 55, the current implementation will also
>>> return bridges 1 to 5.
> 
>> Oh I see it. Now a question: how is it possible that by specifying 
>> offset=50 and limit=10, you have bridges from 1 to 5? Since you're 
>> skipping 50 results and you have only 45 bridges, makes sense to me
>> to return nothing.
> 
>> The logic then is to treat nodes' data as a tape? When I hit the
>> border (the limit) the system should start from the beginning?
> 
>> After clarified that I'll change it to make it
>> backward-compatible.
> 
> Here's an actual example:
> 

Ok, now I got it completely and I'm working on a fix to make onionoo-ng
working as expected, thanks!

> 
> I'm not talking about multiple fields here, but about different values
> of a single field.  And this doesn't have to be complicated, we'll
> just need to specify how values are sorted.  In other words, you'd
> have to write this down for the protocol specification, and without
> linking to how ElasticSearch sorts, because Onionoo users shouldn't
> have to even notice that there's ElasticSearch behind Onionoo.
> 
Sure, I'll put down some wording about that.

> 
> Yes, it says "should", not "must".  The following two queries return
> the same relay, where the second fingerprint is the SHA-1 value of the
> first fingerprint:

Oh ok. So the approach to 'lookup' is:
- make a query for the given hex string
- if no results, assume the given string is SHA-1 hashed
- ? hashes all the fingerprint to match the given string ?

> 
> Yes, but you'll have to do that for _all_ parameters except for
> "fingerprint".
> 

I though the dataset we have already included all the running nodes
within 7 days. So, to return those, should I filter for last_seen_days
>= 7 days ? (will try to look at the code later on)

Thanks

-- 
Anathema

+------------------------------------------------------------------+
   GPG/PGP KeyID: CFF94F0A available on http://pgpkeys.mit.edu:11371/
   Fingerprint: 80CE EC23 2D16 143F 6B25  6776 1960 F6B4 CFF9 4F0A

   https://keybase.io/davbarbato
+------------------------------------------------------------------+