[metrics-bugs] #33617 [Core Tor/Tor]: Add a BandwidthStatistics option and consensus parameter

[Tor Bug Tracker & Wiki]

#33617: Add a BandwidthStatistics option and consensus parameter
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:
                                                 |  MrSquanchee
     Type:  enhancement                          |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.4.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  extra-review, prop313, ipv6,         |  Actual Points:
  outreachy-ipv6, network-team-roadmap-2020Q1    |
Parent ID:  #33052                               |         Points:  1
 Reviewer:  asn                                  |        Sponsor:
                                                 |  Sponsor55-can
-------------------------------------------------+-------------------------

Comment (by MrSquanchee):

 Hii, asn.
 1. `rep_hist_bw_stats_write()` gets called from
 `write_stats_file_callback` in mainloop.c.
  This function handles disk write for all the stats produced.
  So, do you want exhaustive unit-tests for `write_stats_file_callback`,
 which would test
  for all the stats ?? or should I write unit tests for
 `write_stats_file_callback`
  pertaining only to the bandwidth statistics ??
 2. Also, `rep_hist_bw_stats_write()` writes the stats to the disk, so does
 many other stat
  functions, but I haven't yet seen a unit test that tests for a directory
 and contents of
  a file maybe for some reasons I don't know or maybe I am wrong and you
 can point me to
  an appropriate test.
  Would you like to explain how I can write such a test  ??

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33617#comment:38>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online