[metrics-bugs] #31422 [Circumvention/BridgeDB]: Make BridgeDB report internal metrics
Tor Bug Tracker & Wiki
blackhole at torproject.org
Wed Jun 10 19:31:32 UTC 2020
#31422: Make BridgeDB report internal metrics
-------------------------------------------------+-------------------------
Reporter: phw | Owner: phw
Type: enhancement | Status:
| needs_information
Priority: Medium | Milestone:
Component: Circumvention/BridgeDB | Version:
Severity: Normal | Resolution:
Keywords: s30-o21a1, anti-censorship- | Actual Points:
roadmap-2020 |
Parent ID: #31274 | Points: 2
Reviewer: agix | Sponsor:
| Sponsor30-can
-------------------------------------------------+-------------------------
Comment (by phw):
Replying to [comment:19 karsten]:
> Regarding the whiskers, I noticed that these are typically calculated
differently than by your patch. Quoting the source of all truth:
>
> > The same data set can also be represented as a boxplot shown in Figure
3. From above the upper quartile, a distance of 1.5 times the IQR is
measured out and a whisker is drawn up to the '''largest observed point
from the dataset''' that falls within this distance. Similarly, a distance
of 1.5 times the IQR is measured out below the lower quartile and a
whisker is drawn up to the '''lower observed point from the dataset'''
that falls within this distance. All other observed points are plotted as
outliers.[5] (https://en.wikipedia.org/wiki/Box_plot)
>
> In your test case you'd check for `lower-whisker` to be `1.0` and
`upper-whisker` to be `3.0`.
[[br]]
That's a good catch, thanks. Fixed in the
[https://github.com/NullHypothesis/bridgedb/commit/52f2dce2296f324eb09a152d72976bf8f11fcac6
latest commit].
[[br]]
> > On an unrelated note: Karsten, do we need to coordinate on when we
deploy this patch? Note that the patch bumps the key `bridgedb-metrics-
version` to 2 and adds several new fields for our internal metrics. Does
this break anything on the metrics side of things?
>
> I think this should just work, but do you mind providing a sample
version 2 document for me to check?
[[br]]
There you go:
{{{
bridgedb-metrics-end 2020-06-10 17:57:24 (60 s)
bridgedb-metrics-version 2
bridgedb-metric-count https.scramblesuit.??.success.none 10
bridgedb-metric-count https.obfs4.??.success.none 10
bridgedb-metric-count https.vanilla.??.success.none 10
bridgedb-metric-count internal.moat.byipv4-bysubring1of4 20
bridgedb-metric-count internal.moat.byipv4-bysubring2of4 20
bridgedb-metric-count internal.moat.byipv4-bysubring3of4 20
bridgedb-metric-count internal.moat.byipv4-bysubring4of4 20
bridgedb-metric-count internal.moat.byipv6-bysubring1of4 20
bridgedb-metric-count internal.moat.byipv6-bysubring2of4 20
bridgedb-metric-count internal.moat.byipv6-bysubring3of4 20
bridgedb-metric-count internal.moat.byipv6-bysubring4of4 20
bridgedb-metric-count internal.https.byipv4-bysubring1of4 20
bridgedb-metric-count internal.https.byipv4-bysubring2of4 20
bridgedb-metric-count internal.https.byipv4-bysubring3of4 20
bridgedb-metric-count internal.https.byipv4-bysubring4of4 20
bridgedb-metric-count internal.https.byipv6-bysubring1of4 20
bridgedb-metric-count internal.https.byipv6-bysubring2of4 20
bridgedb-metric-count internal.https.byipv6-bysubring3of4 20
bridgedb-metric-count internal.https.byipv6-bysubring4of4 20
bridgedb-metric-count internal.email.byipv4 50
bridgedb-metric-count internal.email.byipv6 50
bridgedb-metric-count internal.unallocated.unallocated 10
bridgedb-metric-count internal.handouts.ipv4 10
bridgedb-metric-count internal.handouts.median 3
bridgedb-metric-count internal.handouts.min 1
bridgedb-metric-count internal.handouts.max 6
bridgedb-metric-count internal.handouts.unique-bridges 3
bridgedb-metric-count internal.handouts.quartile1 2
bridgedb-metric-count internal.handouts.quartile3 4
bridgedb-metric-count internal.handouts.lower-whisker 1
bridgedb-metric-count internal.handouts.upper-whisker 6
}}}
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31422#comment:20>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the metrics-bugs
mailing list