[metrics-bugs] #34191 [Metrics/Onionperf]: Combine multiple analysis files into single data set
Tor Bug Tracker & Wiki
blackhole at torproject.org
Wed Jun 3 10:18:23 UTC 2020
#34191: Combine multiple analysis files into single data set
-------------------------------+--------------------------------
Reporter: karsten | Owner: acute
Type: enhancement | Status: needs_revision
Priority: Medium | Milestone:
Component: Metrics/Onionperf | Version:
Severity: Normal | Resolution:
Keywords: | Actual Points: 0.8
Parent ID: #33321 | Points: 0.5
Reviewer: karsten | Sponsor: Sponsor59-must
-------------------------------+--------------------------------
Comment (by acute):
Replying to [comment:8 karsten]:
> Quick thought: How about we accept a single `PATH` argument (followed by
the `LABEL` argument) but accept a file or directory or (quoted) path
pattern expanded by OnionPerf rather than the shell? The command in your
example would then be: `onionperf visualize -d "onionperf-2019-11/*/*nl*"
nov2019 -d ...` (note the quotes). Untested! After all, if the user wants
to use spaces in their labels, they'll have to quote the label, too.
This could work - the only possible issues would be shell compatibility,
and, of course, the user would still have to create directories if wanting
to aggregate measurements over say, different instances or files without
similar names.
I pushed fixes to address the label and usage concerns you had previously:
https://github.com/ana-cc/onionperf/commits/34191
However, if there are still objections to accepting multiple paths, I can
explore the option you suggest here.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/34191#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the metrics-bugs
mailing list