[metrics-bugs] #28871 [Metrics/Onionoo]: Relay with 6 weeks downtime only has 6_months and 5_years bandwidth graphs

[Tor Bug Tracker & Wiki]

#28871: Relay with 6 weeks downtime only has 6_months and 5_years bandwidth graphs
-----------------------------+------------------------------
 Reporter:  karsten          |          Owner:  metrics-team
     Type:  defect           |         Status:  needs_review
 Priority:  Low              |      Milestone:
Component:  Metrics/Onionoo  |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:                   |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:                   |        Sponsor:
-----------------------------+------------------------------
Changes (by karsten):

 * status:  new => needs_review


Comment:

 The issue is this sentence in the specification: ''"A graph history object
 is only contained if the time period it covers is not already contained in
 another graph history object with shorter time period and higher data
 resolution."''

 In this case, the "1 year" graph would contain the same information that
 was already contained in the "6 months" graph just at a loger data
 resolution, so we're not generating a "1 year" graph at all. We are,
 however, including a "5 years" graph, because the relay reported data for
 the time between 1 and 5 years back in the past.

 The original idea behind this design decision was that the Onionoo server
 could save a few bytes by not including redundant information and that
 Onionoo clients would use data from all compiled graphs that falls into
 the time frame they want to plot. Maybe that decision was too data-centric
 and not developer-friendly enough.

 Let's change this by including all graphs for which we have data for,
 which in this case includes the "1 month" graph as well.

 Requires a major protocol update to 8.0.

 Please review
 [https://gitweb.torproject.org/user/karsten/onionoo.git/commit/?h=tasks-28871-and-27981&id=87abfdd1d939d0cdbeece01a15a07ded850af799
 commit 87abfdd in my tasks-28871-and-27981 branch].

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28871#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online