[metrics-bugs] #30659 [Metrics/CollecTor]: op-ab torperf files are not cleaned up in recent

[Tor Bug Tracker & Wiki]

#30659: op-ab torperf files are not cleaned up in recent
-------------------------------+-----------------------------------
 Reporter:  irl                |          Owner:  metrics-team
     Type:  defect             |         Status:  needs_information
 Priority:  Medium             |      Milestone:
Component:  Metrics/CollecTor  |        Version:
 Severity:  Normal             |     Resolution:
 Keywords:                     |  Actual Points:
Parent ID:                     |         Points:
 Reviewer:                     |        Sponsor:
-------------------------------+-----------------------------------
Changes (by karsten):

 * status:  new => needs_information


Comment:

 I believe this is not an issue.

 Here's what I think has happened: We're using a local file `stats
 /onionperf-downloaded` where we keep full URLs of `.tpf` files that we
 have downloaded before. This file contained lots of lines like the
 following until a few days before:

 {{{
 https://op-ab.onionperf.torproject.net/op-ab-1048576-2019-01-10.tpf
 }}}

 With the port change on op-ab all URLs have changed like the following:

 {{{
 https://op-ab.onionperf.torproject.net:8443/op-ab-1048576-2019-01-10.tpf
 }}}

 As a result we downloaded all files from op-ab once again and overwrote
 the existing files that we had.

 This shouldn't cause problems with tarballs, because those files were
 sorted into monthly folders that we're not tarring up anymore.

 It did cause minor issues with the `recent/` directory, because we're
 keeping files there until their last-modified time is older than three
 days. Most of the new files will simply go away tomorrow.

 Setting to needs_information until we're sure that this is what happened.
 Will check once more and close in a few days.

 Thanks for the report!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30659#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online