[metrics-bugs] #32842 [Core Tor/DocTor]: Give notifications if tor26 is missing from the consensus

[Tor Bug Tracker & Wiki]

#32842: Give notifications if tor26 is missing from the consensus
-----------------------------+------------------------
 Reporter:  Sebastian        |          Owner:  atagar
     Type:  defect           |         Status:  closed
 Priority:  Medium           |      Milestone:
Component:  Core Tor/DocTor  |        Version:
 Severity:  Normal           |     Resolution:  fixed
 Keywords:                   |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:                   |        Sponsor:
-----------------------------+------------------------

Comment (by starlight):

 I object to removing DIRAUTH_SKIP_REACHABLE and DIRAUTH_SKIP_SEEN:

 a) spent several hours testing and making certain they work (touch-up fix
 attached)
 b) they are based on the code you had running in production
 c) because they are tested it will save time if/when needed, just add
 dirauth names

 The touch-up patch contains:

 Trailing comma in the single entry DIRAUTH_SKIP_CHECKS tuple def,
 otherwise it becomes a scalar and set() converts it to a set of
 characters.  Important.

 Fix to the seen-in-consensus test, must subtract the skip list from _both_
 known_authorities and seen_authorities.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32842#comment:19>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online