[metrics-bugs] #9316 [Circumvention/BridgeDB]: BridgeDB should export statistics

[Tor Bug Tracker & Wiki]

#9316: BridgeDB should export statistics
-------------------------------------------------+-------------------------
 Reporter:  asn                                  |          Owner:  phw
     Type:  task                                 |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:
Component:  Circumvention/BridgeDB               |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  metrics, bridgedb, prometheus,       |  Actual Points:
  anti-censorship-roadmap-september              |
Parent ID:  #31274                               |         Points:  3
 Reviewer:  cohosh                               |        Sponsor:
                                                 |  Sponsor30-must
-------------------------------------------------+-------------------------
Changes (by phw):

 * status:  needs_information => needs_review


Comment:

 Replying to [comment:32 cohosh]:
 > This looks good to me, I added some comments to this commit:
 https://github.com/NullHypothesis/bridgedb/commit/d6fa8e18dd764cbc612f834338cb71c4ab322a9b
 [[br]]
 Thanks. My latest branch should include all your feedback:
 https://github.com/NullHypothesis/bridgedb/commits/fix/9316
 [[br]]
 > There were some changes that I couldn't track how they relate to the
 metrics feature, perhaps they snuck in from some other changes being made
 to bridgedb? Otherwise it looks really good!
 [[br]]
 Right, I split the branch into three commits, to make it less confusing.
 [https://github.com/NullHypothesis/bridgedb/commit/0d5ed52e5906260e142ef9cfa12752810fd1ffa2
 0d5ed52e] fixes the broken download of Tor exit relays,
 [https://github.com/NullHypothesis/bridgedb/commit/85a69d1be3f14a8ba0c5ba8e4840e40214217941
 85a69d1b] updates a comment, and
 [https://github.com/NullHypothesis/bridgedb/commit/91d12652065f7912a6a8fe12bee27fc9dcaeb842
 91d12652] implements the metrics feature.
 [[br]]
 > There might be an unchecked failure case
 [https://github.com/NullHypothesis/bridgedb/blob/d1a70dee2ca476b0819a1cb24212215e31c755d6/bridgedb/distributors/moat/server.py#L741
 here] with the moat reporting for when we don't have any bridge lines to
 return. It's not really a failure of the system though so much as a lack
 of bridges so I'm not sure how we'd want to count that.
 [[br]]
 The current metrics implementation is user-centric, meaning that requests
 are classified as "success" if the user did everything right and "fail" if
 the user did something wrong (e.g., used an email account other than Gmail
 or Riseup, or failed to solve the CAPTCHA).

 We probably also want BridgeDB-centric metrics such as "number of bridges
 per ring" and "number of requests that were answered with 0 bridges". I
 suggest that we discuss these in a separate ticket, ok?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9316#comment:34>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online