[metrics-bugs] #9316 [Circumvention/BridgeDB]: BridgeDB should export statistics

[Tor Bug Tracker & Wiki]

#9316: BridgeDB should export statistics
-------------------------------------------------+-------------------------
 Reporter:  asn                                  |          Owner:  phw
     Type:  task                                 |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:
Component:  Circumvention/BridgeDB               |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  metrics, bridgedb, prometheus,       |  Actual Points:
  anti-censorship-roadmap-september              |
Parent ID:  #31274                               |         Points:  3
 Reviewer:  cohosh                               |        Sponsor:
                                                 |  Sponsor30-must
-------------------------------------------------+-------------------------

Comment (by cohosh):

 This looks good to me, I added some comments to this commit:
 https://github.com/NullHypothesis/bridgedb/commit/d6fa8e18dd764cbc612f834338cb71c4ab322a9b

 There were some changes that I couldn't track how they relate to the
 metrics feature, perhaps they snuck in from some other changes being made
 to bridgedb? Otherwise it looks really good!

 There might be an unchecked failure case
 [https://github.com/NullHypothesis/bridgedb/blob/d1a70dee2ca476b0819a1cb24212215e31c755d6/bridgedb/distributors/moat/server.py#L741
 here] with the moat reporting for when we don't have any bridge lines to
 return. It's not really a failure of the system though so much as a lack
 of bridges so I'm not sure how we'd want to count that.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9316#comment:32>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online