[metrics-bugs] #28116 [Metrics/Statistics]: Split up legacy module into more maintainable parts

[Tor Bug Tracker & Wiki]

#28116: Split up legacy module into more maintainable parts
--------------------------------+------------------------------
 Reporter:  karsten             |          Owner:  karsten
     Type:  enhancement         |         Status:  needs_review
 Priority:  Medium              |      Milestone:
Component:  Metrics/Statistics  |        Version:
 Severity:  Normal              |     Resolution:
 Keywords:                      |  Actual Points:
Parent ID:                      |         Points:
 Reviewer:                      |        Sponsor:
--------------------------------+------------------------------
Changes (by karsten):

 * status:  assigned => needs_review


Comment:

 Has it been 10 days since I created this ticket. And I didn't do much else
 than work on this ticket since then. Whee, not a trivial amount of work.

 Alright. I finally have a branch that implements the second suggested
 change: extend the ipv6servers module to produce statistics on
 relays/bridges by relay flag, version, and platform.

 Please review [https://gitweb.torproject.org/user/karsten/metrics-
 web.git/commit/?h=task-28116-2&id=f3ceaa3cd229a6ab653e8c1b1b32031da8a8e091
 commit f3ceaa3 in my task-28116-2 branch]. I admit, it's a lot of new
 code. But it's going to let us to remove a lot of old code, too!

 So, when this code is reviewed, merged, and deployed, the result is that
 four existing graphs look pretty much as they looked before. Ohhhhh.

 That's why I made another graph to showcase the cool new data that this
 extension/rewrite produces as a by-product:

 [[Image(versions-2018-10-29.png, 700px)]]

 Here's what's new in this graph:
  - By version it considers -dev, -alpha, -beta, -rc, and stable versions
 rather than x.y.z version numbers. Both perspectives can be useful, but
 this perspective was not possible with the legacy database.
  - Consensus weight fraction and the various guard/middle/exit
 probabilities were not available in the legacy database.
  - The legacy database did not have any numbers for bridges. The new
 ipv6servers database has them, including bridge numbers by relay flag and
 platform.

 We can make more graphs later. But we first need to replace existing data,
 so let's prioritize that.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28116#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online