[metrics-bugs] #25383 [Metrics/Website]: Deprecate stats.html and stats/*.csv files
Tor Bug Tracker & Wiki
blackhole at torproject.org
Wed May 16 17:37:04 UTC 2018
#25383: Deprecate stats.html and stats/*.csv files
-----------------------------+------------------------------
Reporter: karsten | Owner: karsten
Type: enhancement | Status: needs_review
Priority: High | Milestone:
Component: Metrics/Website | Version:
Severity: Normal | Resolution:
Keywords: | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
-----------------------------+------------------------------
Comment (by karsten):
Replying to [comment:18 iwakeh]:
> Replying to [comment:16 karsten]:
> > Alright, I now have some code to review. This code implements my
latest suggestion above. The R code is tested, the one-line Java code
change is not. Please take a look at
[https://gitweb.torproject.org/karsten/metrics-web.git/log/?h=task-25383
my task-25383] branch with two commits, 0975ca1 and d3b280a.
>
> The second commit looks ok. Regarding the first commit: Interesting, I
wasn't aware of the `!!` operator in R. But, why can't we change the
(Java) calls of the R functions and have different names for parameters
and columns? This would be more readable.
I thought about that, too, but figured it would be a bigger change now.
But I'm open to the idea. What do you suggest? Add `_` to parameter names?
Or `_param`? Like:
{{{
write_networksize <- function(start, end, path) { ... }
# a)
write_networksize <- function(start_, end_, path_) { ... }
# b)
write_networksize <- function(_start, _end, _path) { ... }
# c)
write_networksize <- function(start_param, end_param, path_param) { ... }
# d)
}}}
> > - Decide how we announce and make changes in the future, in
particular backward-incompatible ones. For example, Onionoo has a
`"next_major_version_scheduled"` field to announce backward-incompatible
changes, and we need something like that, too.
>
> Good question! Should this be a part of the comment in the csv file?
Yes, maybe!
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25383#comment:19>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the metrics-bugs
mailing list