[metrics-bugs] #25241 [Metrics/Onionoo]: effective_family sometimes contains the relay's own fingerprint

[Tor Bug Tracker & Wiki]

#25241: effective_family sometimes contains the relay's own fingerprint
-----------------------------+------------------------------
 Reporter:  irl              |          Owner:  karsten
     Type:  defect           |         Status:  needs_review
 Priority:  Medium           |      Milestone:
Component:  Metrics/Onionoo  |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:                   |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:  iwakeh           |        Sponsor:
-----------------------------+------------------------------

Comment (by irl):

 Currently Relay Search removes the relay. This means it has to iterate
 over 2000 (worst case) lists to remove fingerprints for the search view as
 effective family count is shown in the results table. When I added the
 code to filter the fingerprints, I added a comment to say this was
 temporary and should be removed after this ticket was resolved.

 https://gitweb.torproject.org/atlas.git/commit/?id=409e410b5c10666c202cd56b2ff42db0c0a8f766

 The important thing to achieve in this ticket is consistency. My comment
 was not very clear, it's a different change that should be made in Relay
 Search depending on which way we choose to go making it consistent.

 If we always add the relay to its family:

 * Stop filtering the relay's own fingerprint
 * Stop adding 1 to the effective family count

 If we always remove the relay from its family:

 * Stop filtering the relay's own fingerprint
 * Continue to add 1 to the effective family count

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25241#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online