[metrics-bugs] #25241 [Metrics/Onionoo]: effective_family sometimes contains the relay's own fingerprint

[Tor Bug Tracker & Wiki]

#25241: effective_family sometimes contains the relay's own fingerprint
-----------------------------+------------------------------
 Reporter:  irl              |          Owner:  karsten
     Type:  defect           |         Status:  needs_review
 Priority:  Medium           |      Milestone:
Component:  Metrics/Onionoo  |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:                   |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:  iwakeh           |        Sponsor:
-----------------------------+------------------------------

Comment (by karsten):

 Hmm. Interesting idea. Some thoughts/questions:
  - What would the `"effective_family"` field contain if a relay is not in
 an effective family with any other relay?
  - The suggestion is to include the relay itself to `"effective_family"`
 only, and not to `"alleged_family"` or `"indirect_family"`, right?

 I'm open to this idea, especially if it makes processing easier for
 Onionoo clients. It's a bit redundant to include the same fingerprint
 twice in a document, but we made similar decisions in the past where some
 redundancy is acceptable if that makes it easier to process results.

 I'll look closer at the branch as soon as we have made a decision here.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25241#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online