[metrics-bugs] #26699 [Metrics/Library]: Use temporary files for storing descriptor files fetched from remote CollecTor server
Tor Bug Tracker & Wiki
blackhole at torproject.org
Mon Jul 9 12:54:39 UTC 2018
#26699: Use temporary files for storing descriptor files fetched from remote
CollecTor server
---------------------------------+--------------------------
Reporter: karsten | Owner: metrics-team
Type: enhancement | Status: new
Priority: Medium | Milestone:
Component: Metrics/Library | Version:
Severity: Normal | Keywords:
Actual Points: | Parent ID:
Points: | Reviewer:
Sponsor: |
---------------------------------+--------------------------
In #24153 we fixed a bug related to storing descriptor files fetched from
a remote CollecTor server. We also briefly discussed using
`Files.createTempFile()` for storing files, but we decided against doing
that. Let's reconsider doing it when we have more time on our hands.
Copied from irl's comment on that other ticket: ''`Files.createTempFile`
only creates the empty file and gives you a `Path`. The file is actually
permanent (although the operating system may clean it up once the process
exits) unless you open it with `DELETE_ON_CLOSE` on use `.deleteOnExit()`.
([[https://docs.oracle.com/javase/9/docs/api/java/nio/file/Files.html
#createTempFile-java.nio.file.Path-java.lang.String-java.lang.String-
java.nio.file.attribute.FileAttribute...-|ref]]) One benefit might be that
using tmpfs for intermediate files reduces disk I/O and speeds things up.
If we're memory constrained and it becomes an issue though, we should make
sure that the default temporary directory is overridden to a location on
disk.''
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26699>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the metrics-bugs
mailing list