[metrics-bugs] #24153 [Metrics/Library]: Make DescriptorCollector resume previously aborted downloads

[Tor Bug Tracker & Wiki]

#24153: Make DescriptorCollector resume previously aborted downloads
-----------------------------+-----------------------------
 Reporter:  karsten          |          Owner:  karsten
     Type:  defect           |         Status:  merge_ready
 Priority:  Medium           |      Milestone:
Component:  Metrics/Library  |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:                   |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:  irl              |        Sponsor:
-----------------------------+-----------------------------
Changes (by irl):

 * status:  needs_review => merge_ready


Comment:

 Looks good to me.

 For the new ticket: `Files.createTempFile` only creates the empty file and
 gives you a `Path`. The file is actually permanent (although the operating
 system may clean it up once the process exits) unless you open it with
 `DELETE_ON_CLOSE` on use `.deleteOnExit()`.
 ([[https://docs.oracle.com/javase/9/docs/api/java/nio/file/Files.html
 #createTempFile-java.nio.file.Path-java.lang.String-java.lang.String-
 java.nio.file.attribute.FileAttribute...-|ref]]) One benefit might be that
 using tmpfs for intermediate files reduces disk I/O and speeds things up.
 If we're memory constrained and it becomes an issue though, we should make
 sure that the default temporary directory is overridden to a location on
 disk.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24153#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online