[metrics-bugs] #25392 [Metrics/Website]: Adapt Relay Search integration to Metrics' project standards
Tor Bug Tracker & Wiki
blackhole at torproject.org
Mon Jul 2 13:49:44 UTC 2018
#25392: Adapt Relay Search integration to Metrics' project standards
-----------------------------+------------------------------
Reporter: iwakeh | Owner: metrics-team
Type: defect | Status: needs_review
Priority: Medium | Milestone:
Component: Metrics/Website | Version:
Severity: Normal | Resolution:
Keywords: | Actual Points:
Parent ID: | Points:
Reviewer: karsten | Sponsor:
-----------------------------+------------------------------
Changes (by irl):
* status: needs_revision => needs_review
Comment:
Replying to [comment:13 karsten]:
> Okay, this went faster than it looked on first sight. I found two minor
things:
> - Those `.class` files in `bin/` should probably not be in the
repository. Can you remove them in a fixup commit that I can squash into
714ae2d?
Looks like these were added by Eclipse while I wasn't looking. Fixed.
> - There are now unused files in `src/main/resources/web/images/`, like
`atlas.png` and `atlas.xcf`. Would you want to look out for other unused
images and remove those, too, possibly in a separate (non-fixup) commit?
Fixed this too. There are probably other things to tidy up, but would be
smaller patches. Once this is merged, it would be easier to make more
localised patches to address individual things and queue those up.
> I can merge and deploy later today.
Awesome. (:
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25392#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the metrics-bugs
mailing list