[metrics-bugs] #25712 [Metrics/Library]: Replace ServerDescriptor#getHiddenServiceDirVersions with ServerDescriptor#isHiddenServiceDir

[Tor Bug Tracker & Wiki]

#25712: Replace ServerDescriptor#getHiddenServiceDirVersions with
ServerDescriptor#isHiddenServiceDir
---------------------------------+----------------------
     Reporter:  karsten          |      Owner:  karsten
         Type:  enhancement      |     Status:  assigned
     Priority:  Medium           |  Milestone:
    Component:  Metrics/Library  |    Version:
     Severity:  Normal           |   Keywords:
Actual Points:                   |  Parent ID:
       Points:                   |   Reviewer:
      Sponsor:                   |
---------------------------------+----------------------
 Tor has never supported versions in the hidden-service-dir descriptor
 line. See the recently closed #25284.

 We should probably reflect this by replacing
 `ServerDescriptor#getHiddenServiceDirVersions` with
 `ServerDescriptor#isHiddenServiceDir`.

 I'm posting a branch in a minute.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25712>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online