[metrics-bugs] #20549 [Metrics/CollecTor]: Implement SanitizedBridgeServerDescriptor class that encapsulates the sanitizing logic for bridge server descriptors
Tor Bug Tracker & Wiki
blackhole at torproject.org
Fri Oct 27 17:37:17 UTC 2017
#20549: Implement SanitizedBridgeServerDescriptor class that encapsulates the
sanitizing logic for bridge server descriptors
-------------------------------+------------------------------
Reporter: iwakeh | Owner: metrics-team
Type: enhancement | Status: needs_review
Priority: Medium | Milestone:
Component: Metrics/CollecTor | Version:
Severity: Normal | Resolution:
Keywords: metrics-2017 | Actual Points:
Parent ID: #20542 | Points:
Reviewer: | Sponsor:
-------------------------------+------------------------------
Changes (by karsten):
* status: assigned => needs_review
Comment:
Replying to [comment:5 karsten]:
> "While working on this patch I considered taking a different approach
where we'd include placeholders for parts that we cannot sanitize yet and
fill them in after finishing to read the original descriptor. This could
be a `List<StringBuilder>` to retain order of original lines and where
we'd keep references to some `StringBuilder`s that we need to sanitize
after reading. Still something to think about. Let's do that after fixing
this ugly bug."
I started an implementation in [https://gitweb.torproject.org/karsten
/metrics-
db.git/commit/?h=task-20549&id=fcfc2b5f2fc02c17896fb40659c4d8e19f5017ad my
task-20549 branch] that doesn't get us all the way to implementing this
ticket yet, but which may be a start. Feedback welcome!
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20549#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the metrics-bugs
mailing list