[metrics-bugs] #21637 [Metrics/Onionoo]: Include both declared and reachable IPv6 OR addresses

[Tor Bug Tracker & Wiki]

#21637: Include both declared and reachable IPv6 OR addresses
--------------------------------+------------------------------
 Reporter:  teor                |          Owner:  metrics-team
     Type:  enhancement         |         Status:  needs_review
 Priority:  Medium              |      Milestone:
Component:  Metrics/Onionoo     |        Version:
 Severity:  Normal              |     Resolution:
 Keywords:  metrics-2017, ipv6  |  Actual Points:
Parent ID:                      |         Points:
 Reviewer:                      |        Sponsor:
--------------------------------+------------------------------

Comment (by karsten):

 Replying to [comment:12 teor]:
 > Replying to [comment:10 karsten]:
 > > Replying to [comment:9 teor]:
 > > > This is how things will work when authorities upgrade to 0.3.3,
 assuming we merge the IPv6 fixes in #20916.
 > >
 > > Hmm, can you elaborate how either the upgrade or the bugfix will
 affect us here?
 >
 > Authorities will vote Running for relays with unreachable IPv6
 addresses, but drop the unreachable address from the vote.
 > At the moment, they vote not Running, and drop the entire relay from the
 consensus.

 It took me a while to figure out why I'm seeing relays with unreachable
 IPv6 address and the Running flag in the consensus. Turns out that only
 tor26 and gabelmoo check whether an IPv6 address is reachable and hence
 remove the Running flag from relays in their vote. But given that all the
 other authorities don't perform this check and assign the Running flag to
 relays, they end up in the consensus as Running. And #20916 will fix the
 part about votes not containing the Running flag for these relays? If so,
 okay. This shouldn't block deploying this Onionoo feature, though.

 I also found a minor bug in my branch and pushed a fixup commit.

 I'd say that
 [https://gitweb.torproject.org/user/karsten/onionoo.git/log/?h=task-21637
 my updated task-21637 branch] is ready for code review now!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21637#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online