[metrics-bugs] #22695 [Metrics/metrics-lib]: descriptor file processing

[Tor Bug Tracker & Wiki]

#22695: descriptor file processing
---------------------------------+------------------------------
 Reporter:  iwakeh               |          Owner:  metrics-team
     Type:  defect               |         Status:  new
 Priority:  High                 |      Milestone:
Component:  Metrics/metrics-lib  |        Version:
 Severity:  Normal               |     Resolution:
 Keywords:                       |  Actual Points:
Parent ID:                       |         Points:
 Reviewer:                       |        Sponsor:
---------------------------------+------------------------------

Comment (by karsten):

 Replying to [comment:6 iwakeh]:
 > Why not throw out the File parameter?

 We want the `File` reference to be set in every `Descriptor` that
 `DescriptorParser` returns. We could indeed throw out the `File` parameter
 and set it ourselves.

 > If byte arrays are supplied the filename parameter can be used for
 adding the 'source' to the descriptor raw bytes, which may be useful for
 debugging/troubleshooting and identifying weird descriptors.

 I'd rather get rid of it.

 > Or, turn filename into a `sourceMarker` string?

 The issue is that we sometimes parse parts from the filename and include
 it in the `Descriptor`. I want to change that. But not before 2.0.0 comes
 out. :)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22695#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online