[metrics-bugs] #22652 [Metrics/metrics-lib]: Adapt CollecTor to metrics-lib 1.9.0

[Tor Bug Tracker & Wiki]

#22652: Adapt CollecTor to metrics-lib 1.9.0
---------------------------------+------------------------------
 Reporter:  iwakeh               |          Owner:  metrics-team
     Type:  enhancement          |         Status:  needs_review
 Priority:  Medium               |      Milestone:
Component:  Metrics/metrics-lib  |        Version:
 Severity:  Normal               |     Resolution:
 Keywords:                       |  Actual Points:
Parent ID:                       |         Points:
 Reviewer:                       |        Sponsor:
---------------------------------+------------------------------

Comment (by karsten):

 Thanks for that branch!  A quick review looks okay, but I'm running into
 the following exception (with some additional logging output) when syncing
 bridge descriptors:

 {{{
 2017-06-19 13:27:44,995 ERROR o.t.c.s.SyncPersistence:114
 desc.class=BridgeNetworkStatusImpl, filename=statuses
 java.lang.ArrayIndexOutOfBoundsException: 2
         at
 org.torproject.collector.sync.SyncPersistence.storeDesc(SyncPersistence.java:112)
 ~[collector-1.1.2-dev.jar:1.1.2-dev-15cf44d]
         at
 org.torproject.collector.sync.SyncManager.mergeWithLocalStorage(SyncManager.java:110)
 [collector-1.1.2-dev.jar:1.1.2-dev-15cf44d]
         at
 org.torproject.collector.sync.SyncManager.merge(SyncManager.java:44)
 [collector-1.1.2-dev.jar:1.1.2-dev-15cf44d]
         at
 org.torproject.collector.cron.CollecTorMain.run(CollecTorMain.java:76)
 [collector-1.1.2-dev.jar:1.1.2-dev-15cf44d]
         at
 java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
 [na:1.8.0_121]
         at java.util.concurrent.FutureTask.run(FutureTask.java:266)
 [na:1.8.0_121]
         at
 java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
 [na:1.8.0_121]
         at java.util.concurrent.FutureTask.run(FutureTask.java:266)
 [na:1.8.0_121]
         at
 java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)
 [na:1.8.0_121]
         at
 java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
 [na:1.8.0_121]
         at
 java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
 [na:1.8.0_121]
         at
 java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
 [na:1.8.0_121]
         at java.lang.Thread.run(Thread.java:745) [na:1.8.0_121]
 }}}

 It's quite possible that this issue existed before the current change.  I
 didn't spot the bug, but maybe it's easy for you to look?  If not, I'll
 investigate in more detail.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22652#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online