[metrics-bugs] #21171 [Metrics/Onionoo]: write a test for NodeDetailsStatusUpdater

Wed Jul 5 21:23:55 UTC 2017

#21171: write a test for NodeDetailsStatusUpdater
-----------------------------+------------------------------
 Reporter:  iwakeh           |          Owner:  metrics-team
     Type:  enhancement      |         Status:  new
 Priority:  Medium           |      Milestone:
Component:  Metrics/Onionoo  |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:  metrics-help     |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:                   |        Sponsor:
-----------------------------+------------------------------

Comment (by kiki201):

 So, the test should check if a consensus doesn't contain nodes that never
 showed up, so that the code before the commit fails. Is this right?

 However, I'm not sure about how to go about testing this. The project
 contains a mock consensus object that implements
 RelayNetworkStatusConsensus. But, RelayNetworkStatusConsensus is only used
 in processDescriptor. So, I don't know how to take advantage of this
 class. I'm not sure how to simulate the whole process in order to test it.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21171#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online