[metrics-bugs] #21236 [Metrics/Metrics website]: Put a visualization of Tor Browser downloads and updates on the Metrics website
Tor Bug Tracker & Wiki
blackhole at torproject.org
Mon Jan 23 16:06:15 UTC 2017
#21236: Put a visualization of Tor Browser downloads and updates on the Metrics
website
-------------------------------------+------------------------------
Reporter: karsten | Owner: karsten
Type: enhancement | Status: needs_review
Priority: High | Milestone:
Component: Metrics/Metrics website | Version:
Severity: Normal | Resolution:
Keywords: | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
-------------------------------------+------------------------------
Comment (by karsten):
Replying to [comment:13 iwakeh]:
> I have a build file tweak [https://gitweb.torproject.org/user/iwakeh
/metrics-
web.git/commit/?h=task-21236-3&id=5085bd8b1b6715c3924cf6aa633835fa713828fe
here].
Looks good!
> Good to have some tests for a start!
> Wondering, if a test should make explicit that the ending really doesn't
matter, i.e., that `SAMPLE_LOG_FILE_NAME` could be almost anything, but
tests would still pass?
> Or, rather change the matcher to only choose `.xz` files?
Changing the matcher wouldn't work, because we're using it for `.xz` files
as well as subdirectories. Added a test to point this out.
> The result sets etc. could all be ensured to be closed by using try-
with-resources (in most cases w/o any catch).
Changed them all.
> The extended explanation will be useful either preventing questions or
by being the place to point to when questions come up.
Hopefully!
> In general, metrics-web needs quite some work still. But, that'll be
other tickets.
Absolutely! Let's keep this in mind for the next funding proposal.
Please find the [https://gitweb.torproject.org/karsten/metrics-
web.git/commit/?h=task-21236-3&id=520dd4112b7f56a323dc2e32cae4751364f032d4
last commit in my task-21236-3 branch] for the latest fixes. If this
looks good, I'll squash, merge, and deploy (pending on #21277). Thanks!
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21236#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the metrics-bugs
mailing list