[metrics-bugs] #21443 [Metrics/CollecTor]: CollecTor does not delete exit lists after three days anymore

[Tor Bug Tracker & Wiki]

#21443: CollecTor does not delete exit lists after three days anymore
-----------------------------------+--------------------------
     Reporter:  karsten            |      Owner:  metrics-team
         Type:  defect             |     Status:  new
     Priority:  Medium             |  Milestone:
    Component:  Metrics/CollecTor  |    Version:
     Severity:  Normal             |   Keywords:
Actual Points:                     |  Parent ID:
       Points:                     |   Reviewer:
      Sponsor:                     |
-----------------------------------+--------------------------
 Today I learned by a coincidence that CollecTor does not keep its
 directory with [https://collector.torproject.org/recent/exit-lists/ recent
 exit lists] clean anymore.  Here's the bug:

 {{{
 diff --git
 a/src/main/java/org/torproject/collector/exitlists/ExitListDownloader.java
 b/src/main/java/org/torproject/collector/exitlists/ExitListDownloader.java
 index 877057e..0ac5112 100644
 ---
 a/src/main/java/org/torproject/collector/exitlists/ExitListDownloader.java
 +++
 b/src/main/java/org/torproject/collector/exitlists/ExitListDownloader.java
 @@ -199,7 +199,7 @@ public class ExitListDownloader extends CollecTorMain
 {
      long cutOffMillis = System.currentTimeMillis()
          - 3L * 24L * 60L * 60L * 1000L;
      Stack<File> allFiles = new Stack<File>();
 -    allFiles.add(new File(recentPathName, EXITLISTS));
 +    allFiles.add(new File(recentPathName));
      while (!allFiles.isEmpty()) {
        File file = allFiles.pop();
        if (file.isDirectory()) {
 }}}

 This doesn't require a patch release immediately, but having a release
 later this month would be good.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21443>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online