[metrics-bugs] #24218 [Metrics/Statistics]: Implement new metrics-web module for IPv6 relay statistics

[Tor Bug Tracker & Wiki]

#24218: Implement new metrics-web module for IPv6 relay statistics
--------------------------------+------------------------------
 Reporter:  karsten             |          Owner:  metrics-team
     Type:  enhancement         |         Status:  needs_review
 Priority:  Medium              |      Milestone:
Component:  Metrics/Statistics  |        Version:
 Severity:  Normal              |     Resolution:
 Keywords:                      |  Actual Points:
Parent ID:                      |         Points:
 Reviewer:  iwakeh              |        Sponsor:
--------------------------------+------------------------------

Comment (by iwakeh):

 Replying to [comment:12 karsten]:
 > Replying to [comment:11 iwakeh]:
 > > A quick glance tells me there is one
 [https://gitweb.torproject.org/karsten/metrics-web.git/tree/modules
 /servers-ipv6/src/main/resources/init-servers-
 ipv6.sql?h=tasks-24218-23761&id=ba969fe47c2c40949f3c51b6f9e80c9a633a52cc#n97
 'date' column left] in the view, which needs to be renamed.
 >
 > Huh, yes. Fixed now in [https://gitweb.torproject.org/karsten/metrics-
 web.git/commit/?h=tasks-24218-23761&id=3c6b01bcfa27537cafb28a3e31469b932ecb6b39
 commit 3c6b01b] (where I also updated the pgTAP tests which I forget
 earlier).

 Oh, the sql tests were 'hiding' in test resources!  That's why I ignored
 them earlier.  The correct Metrics' environment expects these in
 `test/sql`, which can be done now or when this module is refactored.


 >
 > > I used `psql (PostgreSQL) 9.5.10` (ubuntu), will check with 9.6 later
 (a quick update of my postgres failed :-/
 > > Would be nice to have the 'on conflict'.
 >
 > It also works fine in my Debian squeeze VM. I'll for now assume it's a
 problem with your PostgreSQL version.

 Hmm, debian stretch is the current stable and has
 [https://packages.debian.org/stretch/postgresql 9.6]
 and provides
 [https://packages.debian.org/search?suite=jessie&arch=any&searchon=names&keywords=postgres
 9.4].  Unless our server gets the current stable soon, it might need the
 backported postgres.

 What version is on the old sqeeze?

 >
 > > Regarding the structure I am wondering about more indexes, but these
 could be added later.
 >
 > True, we could add indexes later. Though I didn't spot any obviously
 missing indexes in my tests so far. The largest amount of data I imported
 was 2 years, but I didn't test continuous updates after that. I guess
 we'll learn.

 Ok.

 >
 > > Tests for the sql are missing to verify he results.  Just from reading
 it seems fine, but just reading.
 >
 > I think that what we have as tests is at least a start. To be honest,
 I'm not entirely happy with the JUnit/pgTAP mix here. But I hope that
 we'll improve that over time as we write more modules following this
 schema.
 >
 > Green light for archive import?

 Well, I think it's ok to go.

 Could you change the module path from `modules/servers-ipv6` to
 `modules/ipv6servers` and the package name from `serversipv6` to
 `ipv6servers` before I review the java code?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24218#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online